-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a server cluster interface registry for use by codegen. #37850
Add a server cluster interface registry for use by codegen. #37850
Conversation
PR #37850: Size comparison from 91b3a94 to c3cb1aa Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37850: Size comparison from 13da787 to bbb33e4 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nit comments
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/tests/TestServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Terence Hampson <thampson@google.com>
PR #37850: Size comparison from c31efb2 to e73955c Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, meant to request changes so this does not accidentally merge until we sort out the API bits.
PR #37850: Size comparison from c31efb2 to b60ebad Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This comment was marked as outdated.
This comment was marked as outdated.
Dismissing review due to rather large structural change, so this does not go in without at least a 2nd glance.
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…y.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…y.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…tedhomeip into server_cluster_registry
PR #37850: Size comparison from c31efb2 to 4463e95 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37850: Size comparison from c31efb2 to 2fa2125 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This is the split out registry from #37541 .
NOTE: This is not currently used/integrated in codegen.
Additional implementation notes:
Testing
Fully unit tested.